Tetsuo Handa wrote: > Eric Paris wrote: > > Interesting, is this a result of the compiler previously being able to > > optimize the division since it could tell it was a power of 2 and now > > that we have a private variable it can't? The patch can easily be > > reverted without breaking anyone else.... > I meant to say that it seems that GCC 3.x can optimize #define roundup(x, y) ((((x) + ((y) - 1)) / (y)) * (y)) for roundup((long long), (const)) case but cannot optimize #define roundup(x, y) ( \ { \ typeof(y) __y = y; \ (((x) + (__y - 1)) / __y) * __y; \ } \ ) for roundup((long long), (const)) case. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html