On Fri, Oct 29, 2010 at 02:23:34PM +1100, Dave Chinner wrote: > /* > - * Move the inode off the IO lists and LRU once I_FREEING is > - * set so that it won't get moved back on there if it is dirty. > + * Move the inode off the LRU once I_FREEING is set so that it > + * won't get moved back on. > */ > list_move(&inode->i_lru, &dispose); > - list_del_init(&inode->i_wb_list); a) OK, so you've killed that list_del_init(). Good. b) The comment is completely misleading. We don't put I_FREEING inodes back on LRU (or IO) lists, no matter where we find them. What's happening here is that we are collecting inodes to evict, period. > - * Move the inode off the IO lists and LRU once I_FREEING is > - * set so that it won't get moved back on there if it is dirty. > + * Move the inode off the LRU once I_FREEING is > + * set so that it won't get moved back on. Ditto. > /* > - * Move the inode off the IO lists and LRU once I_FREEING is > - * set so that it won't get moved back on there if it is dirty. > + * Move the inode off the LRU once I_FREEING is > + * set so that it won't get moved back on. > */ Ditto. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
