On Thu, Oct 28, 2010 at 12:30:45PM +0200, Boaz Harrosh wrote: > I've just noticed this patch. Was it posted to linux-fsdevel? Sorry > for missing it. It has been, but only very recently. I can't say I overly like it. There's no real point in dispatching this out to a separate vector instead of just through ->ioctl. It's got rather useless special case for ommiting the argument, and the whole thing just doesn't seem generic enough to do it in the VFS. Why did this common code go in through the ext4 tree as a start, and without hitting linux-next before the merge window? > What is the point of that? sb->s_bdev is not used anywhere in this code. > If an FS published an sb->s_op->trim_fs, it should know what it wants > No? Note that the FS in question does not even need to check. It already > knows if it's block based or not. Indeed. Looks like copied from freeze/thaw which used to be block device based, but don't really need this anymore either. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
