Re: [PATCH 07/19] quota: make per-sb hash array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 22, 2010 at 09:34:52PM +0400, Dmitry Monakhov wrote:
> From: Dmitry Monakhov <dmonakhov@xxxxxxxxx>
> 
> Currently quota_hash[] is global, which is bad for scalability.
> Also is is the last user of global dq_list_lock.
> It is reasonable to introduce dedicated hash for each super_block
> which use quota.
> 
> per-sb hash will be allocated only when necessary (on first quota_on())
> Protected by per-sb dq_list_lock.

Ugh...  Why not a common hash with per-chain spinlock?  We'll waste less
memory on those than on hash chain heads even for a couple of superblocks
and unless you've got boxen with more (quota'd) superblocks than hash chains,
you'll get less contention...
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux