On Sat, Oct 23, 2010 at 09:35:16PM +0200, Miklos Szeredi wrote: > > Another thing: > > "If clone_mnt() happens while mnt_make_readonly() is running, the > > cloned mount might have MNT_WRITE_HOLD flag set, which results in > > mnt_want_write() spinning forever on this mount." > > actually means > > "neither clone_mnt() nor remounts should ever be done without > > namespace_sem held exclusive; if that ever happens, we have a serious > > bug that can lead to any number of bad things happening". > > > > Do you actually see such places? If so, that's what needs fixing. > > do_remount() takes s_umount, but not namespace_sem. Duh... Right, ignore that part; we really don't want to do anything blocking beyond simple allocations under namespace_sem (e.g. everything that gets unmounted is collected to be dropped after namespace_sem is released). Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
