On Thu, Oct 21, 2010 at 11:49:29AM +1100, Dave Chinner wrote: > if (sb->s_flags & MS_ACTIVE) { > + inode->i_state |= I_REFERENCED; > + if (!(inode->i_state & (I_DIRTY|I_SYNC))) { > + list_del_init(&inode->i_list); > + inode_lru_list_add(inode); What if it was on the list already? Looks like you'll screw the counter... And yes, you have solution later in series (do nothing if list isn't empty); should be here for bisectability sake... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html