On 2010-10-20 16:50, Nicolas Kaiser wrote: > It's intended to return an error, right? > > Signed-off-by: Nicolas Kaiser <nikai@xxxxxxxxx> > --- > fs/pipe.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/pipe.c b/fs/pipe.c > index 279eef9..37eb1eb 100644 > --- a/fs/pipe.c > +++ b/fs/pipe.c > @@ -382,7 +382,7 @@ pipe_read(struct kiocb *iocb, const struct iovec *_iov, > error = ops->confirm(pipe, buf); > if (error) { > if (!ret) > - error = ret; > + ret = error; > break; > } > Thanks, that is indeed a bug. I'll commit and mark for stable. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html