On Fri 08-10-10 13:08:06, Christoph Hellwig wrote: > On Fri, Oct 08, 2010 at 07:00:26PM +0400, Dmitry Monakhov wrote: > > inode writeback usually result in quota changes especially > > on filesystems with delalloc. So quota_sync() before writeback > > seems pointless. Let's do the job in a natural way. > > Yes, that's one reason why we can't use the quota sync callback for XFS, > as we need to do it after the actual sync. Then again I'm not even > sure we need to bother with a callout from the writeback code. > Following the model of all other quota code filesystems using quota > should probably just call it from their ->sync_fs method. Note that > this allows allows other optimizations for using the generic quota > code. dquot_quota_sync currently calls ->sync_fs by itself which > could be optimized away by that design. Yes, that would make sense but then we have to change quotactl(Q_SYNC, ...) to result in calling ->sync_fs() as it does now. Because we have to get quota data to disk in response to this call. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
