On Wed, Oct 13, 2010 at 10:49:46AM -0400, Boaz Harrosh wrote: > I suspect it's not a bug but a useless inc/dec because in all my testing > I have not seen an inode leak. Let me investigate if it can be removed. > > So I do not think we need it for 2.6.36. > > I'll take this patch into my 2.6.37-rcX merge window. It should appear > in linux-next by tomorrow. Hopefully followed by a removal patch later. It's a very real bug. If an inode goes away in-core before the creation on the OSD has finished, e.g. by using the drop_cache files the atomic_dec instead of the iput means you will never call iput_final and thus leak all ressources associated with the inode, as well as leaving it on all lists. It's not easy to hit, but very nasty when it is hit. Another option to fix it might be to drop the refcount games and just add a wait for the objection creation in the evict_inode method to make sure we never remove the inode before the object creation has finished. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
