On Fri, Oct 01, 2010 at 02:06:07AM -0400, Christoph Hellwig wrote: > On Wed, Sep 29, 2010 at 10:18:43PM +1000, Dave Chinner wrote: > > From: Nick Piggin <npiggin@xxxxxxx> > > > > Before we can replace the inode hash locking with a more scalable > > mechanism, we need to remove external users of the inode_hash_lock. > > Make it private by adding a function __remove_inode_hash that can be > > called by filesystems instead of open-coding their own inode hash > > removal operations. > > I like the factoring, but this changelog is misleading. At least in > this series no new user of __remove_inode_hash appears, and I'm not sure > where it would appear anyway. Just making the function global without > actually exporting it is not helping external filesystems anyway. For > now it can simply be made static. Yeah, hugetlbfs was using this a while back as I said, and I've missed refactoring it. Will do. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
