Re: [PATCH 07/18] fs: rework icount to be a locked variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -		atomic_inc(&inode->i_count);
> +		spin_lock(&inode->i_lock);
> +		inode->i_ref++;
> +		spin_unlock(&inode->i_lock);

Why isn't this using iref?

> +		spin_lock(&inode->i_lock);
> +		inode->i_ref++;
> +		spin_unlock(&inode->i_lock);

Same here and in a couple of others.

Hmm, I guess because the i_lock later covers other things around.
But it still looks a bit weird.

Except for this stuff the patch looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux