Re: [PATCH 04/11] quota: make dquot lists per-sb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 6 Oct 2010 12:22:24 +0200, Jan Kara <jack@xxxxxxx> wrote:
> On Tue 05-10-10 22:20:20, Dmitry Monakhov wrote:
> > Currently quota lists are global which is very bad for scalability.
> > * inuse_lists -> sb->s_dquot->dq_inuse_list
> > * free_lists  -> sb->s_dquot->dq_free_lists
> > * Add per sb lock for quota's lists protection
> > 
> > Do not remove dq_lists_lock is used now only for protecting quota_hash
>   Hmm, wouldn't be it easier to just convert lists to per-sb ones in this
> patch, convert hash in the next patch, and convert the spinlock in the last
> one. You wouldn't have to have both spinlocks in parallel... But that's
> just a nit ;).
I've hoped that this would be easier to read and review.
IMHO This that approach one may understand my ideas just by looking 
to diff. But if you want i can destroy and reassemble locking logic in
one patch :)

> 
> 								Honza
> -- 
> Jan Kara <jack@xxxxxxx>
> SUSE Labs, CR
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux