On 10/5/2010 10:01 AM, Aneesh Kumar K.V wrote:
Make sure we drop inode reference in the error path Signed-off-by: Aneesh Kumar K.V<aneesh.kumar@xxxxxxxxxxxxxxxxxx>
Looks good to me. Reviewed-by : Venkateswararao Jujjuri <jvrao@xxxxxxxxxxxxxxxxxx>
--- fs/9p/vfs_inode.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index 1ec9075..1ac9229 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c @@ -1028,7 +1028,7 @@ static struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry, result = v9fs_fid_add(dentry, fid); if (result< 0) - goto error; + goto error_iput; inst_out: if (v9ses->cache) @@ -1039,6 +1039,8 @@ inst_out: d_add(dentry, inode); return NULL; +error_iput: + iput(inode); error: p9_client_clunk(fid);
-- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
