On Tue 05-10-10 09:53:41, Boaz Harrosh wrote: > On 10/05/2010 04:32 AM, Jan Kara wrote: > > Hi Boaz, > > > > On Mon 04-10-10 18:02:13, Boaz Harrosh wrote: > >> Sorry I've just seen Jan's patch: > >> From: Jan Kara <jack@xxxxxxx> > >> Date: Mon, 27 Sep 2010 23:56:48 +0200 > >> Subject: [PATCH] bdi: Initialize inode->i_mapping.backing_dev_info to sb->s_bdi > > ... > >> That works for me as well. Was it decided how to solve this? Other wise > >> I'll need to patch exofs, ASAP for this -rc > > In the end, we'll use Christoph's patch > > (http://lkml.org/lkml/2010/9/29/76) changing inode_to_bdi() to be > > more conservative and also the warning will be gone. So you don't have to > > patch anything... > > > I would still like to fix it. Currently each inode->mapping.backing_dev_info in my > none-block-filesystem is set to &default_backing_dev_info. This sounds scary! > what about the future patches that will schedule a wakup on set_inode_dirty ? > Will they not need my proper sb->s_bdi on each ->mapping? Yes, but Christoph is working on separating the bdi handling from handling of writeback (pointed from superblock) and that should solve this problem as well. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
