On Fri, 2010-10-01 at 14:12 -0400, Trond Myklebust wrote: > > However, it looks to me as if the right thing to do when the > page->mapping has changed would be to do the same thing as > block_page_mkwrite(), and just return VM_FAULT_NOPAGE so that the VM > can > retry the fault. > IMO: We should only SIGBUS if the calls to nfs_flush_incompatible() > and/or nfs_updatepage() fail. Well, other filesystems seem to think that if the mapping -changed-, SIGBUS is a good idea... But they don't have to deal with invalidations wiping mappings in the background. So that's why I was thinking about singling out the "mapping became NULL" case and keep the SIGBUS for when the mapping became something else... but that's your call really :-) Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
