On Wed, Sep 29, 2010 at 09:52:29PM -0700, Andrew Morton wrote: > On Wed, 29 Sep 2010 22:18:37 +1000 Dave Chinner <david@xxxxxxxxxxxxx> wrote: > > > - if (atomic_read(&inode->i_count) != 1) > > + if (inode->i_count != 1) > > This really should have been renamed to catch unconverted code. > > Such code usually wouldn't compile anyway, but it will if it takes the > address of i_count only (for example). If people do whacky things they'll lose - there is a reason why C has a fairly strict type system after all. We've changed types of variables all the time and we didn't run into problems. > And maybe we should access this guy via accessor functions, dunno. Seems like complete overkill. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
