On 09/27/2010 06:03 PM, Brad Boyer wrote:
On Mon, Sep 27, 2010 at 12:16:28PM -0700, Matt Helsley wrote:
On Sun, Sep 26, 2010 at 12:08:37PM -0700, Brad Boyer wrote:
On Thu, Sep 23, 2010 at 02:53:28PM -0700, Matt Helsley wrote:
Not all filesystems will necessarily be able to support relinking an
orphan inode back into the filesystem. Some offlist feedback suggested
that instead of overloading .link that relinking should be a separate
file operation for this reason.
In light of Brad's comment (below), maybe elaborate on this:
Some offlist feedback suggested that instead of overloading .link
to provide this functionality, relinking of an orphan inode back
into the filesystem should be a separate file operation.
This is because some filesystems may not be able to support this
operation. Their existing .link already assumes that the inode
isn't orphan (i_nlink != 0), but still won't explicitly test for
the condition. If this is the case, the overloading .link may
break their assumptions and a call to relink may not be handled
too gracefully.
Since .relink is a superset of .link make the VFS call .relink where
possible and .link otherwise.
The next commit will change ext3/4 to enable this operation.
I may have missed something in one of these patches (patch 1 and any
original summary if there was one don't appear in my email), but
what is the point of the new operation? I didn't see any case that
treats one any different than the other. What is disallowed (and how)
for a driver which does not implement .relink but has .link?
Did you get patch 3? It shows how ext3/ext4 add the ability to take an
inode that has been unlinked, placed onto the orphan list, and relink it.
Yes, I did get patch 3. I think you misunderstood my question. You point
both .link and .relink to the same function in ext3 and ext4. The common
code which calls them will call .relink if it is set and .link if it is
not set. If nothing acts any different based on .relink being NULL or
not-NULL, and the only implementation isn't any different from .link
what was the point of introducing a new operation?
What I expected to see was that some particular code path would check
if .relink was NULL and fail in that case. Unless there is a code path
that will only call .relink and not .link, it seems useless to me.
Does the above help clarify this ?
The test performed in vfs_link().
Oren.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
