Re: [PATCH 09/15] cifs: have cifsFileInfo hold a reference to a tlink rather than tcon pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 23 Sep 2010 01:08:51 -0500
Steve French <smfrench@xxxxxxxxx> wrote:

> On Mon, Sep 20, 2010 at 6:01 PM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> > cifsFileInfo needs a pointer to a tcon, but it doesn't currently hold a
> > reference to it. Change it to keep a pointer to a tcon_link instead and
> > hold a reference to it.
> 
> Nice work on these patches but they do end up more complex than I expected
> (may be unavoidable).
> 
> Before committing the last set - are we sure that there is no way we could have
> done the list of tids/uids off the same tcon or simplify.  For example (may be
> impractical, but worth considering) - if we limited many of these changes to
> init_smb itself - if in init_smb we see a request from local uid that does not
> have an smb uid negotiated, we negotiate/sessionsetup/tcon
> there (as we do reconnect today in some cases) to get the new tid - this does
> have the problem of not knowing the uid of the opener of a file though so
> perhaps not problem.
> 
> Your way may be better - but it is a much bigger change.
> 

So essentially what you're proposing is to change the current model
where we track one session per cifsSesInfo struct and one tcon per
cifsTconInfo struct to a model where you'd have multiple UID/TID's
tracked for each?

I suppose that would be one way to do that, but I'm not sure how you
would implement such a model without ripping and replacing a lot of
code. At that point not only does cifs_sb->tcon make no more sense, but
tcon->ses doesn't make any. Doing so would also break the current
hierarchy where a tcon is on the list of one and only one SMB session.

I think taking that approach would lead to a larger change than this
one. This patchset builds upon the current hierarchical model that
we've successfully used for the last few years.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux