On Mon, 06 Sep 2010, NeilBrown wrote: > If we open a directory O_RDONLY, ->realfile could be on the lower > filesystem. > While fsync is not likely to be called on such a file, we should make > sure never to pass the fsync down as we are treating the lower > filesystem as read-only. Why not? fsync() works fine on an r/o filesystem. It doesn't do much, probably, but that's not a reason to add additional complexity. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html