On Fri 20-08-10 15:22:05, Dave Chinner wrote: > The following two patches fix bugs in the new radix tree functionality used to > implement the writeback livelock avoidance code. Both bugs manifest themselves > as stray PAGECACHE_TAG_TOWRITE tags in the mapping->page_tree radix tree > resulting in livelocks during tag lookups. More subtly, they also appear to > result in writeback tree walks occasionally terminating early and so not > actually writing all the pages they are supposed to. Really, how that early termination could happen? I'm just wondering because I don't see that.. The code just mindlessly copies tags regardless of how target flags are set so that's why I'd think that any stale copied flags just don't matter... Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
