Re: [PATCH 12/15] swap: do not send discards as barriers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi.

On 19/08/10 13:47, Hugh Dickins wrote:
On Wed, 18 Aug 2010, Christoph Hellwig wrote:

The swap code already uses synchronous discards, no need to add I/O barriers.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

Acked-by: Hugh Dickins<hughd@xxxxxxxxxx>

(though if you happened to respin, I'd be be glad for those newlines
between GFP_KERNEL, BLKDEV_IFL_WAIT to go away now)

This patch could go in any time now: I may want to push it in and
get it to 35-stable, because it certainly helps against the swap
discard regression that Nigel reported (though I've not yet seen
his numbers with this).  However, I don't think it eliminates the
regression, so I've more testing and experimenting to do before
deciding about it - the right answer may just be to disable swap
discard, as you asked for long ago.

Sorry - I've been busy with other things. I'll seek to get back to this shortly.

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux