Re: [RFC PATCHSET block#for-2.6.36-post] block: convert to REQ_FLUSH/FUA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-08-18 at 11:53 +0200, Christoph Hellwig wrote:
> On Mon, Aug 16, 2010 at 06:51:58PM +0200, Tejun Heo wrote:
> > * scsi_error.c for some reason tests REQ_HARDBARRIER.  I think this
> >   part can be dropped altogether but am not sure.
> 
> That was introduced by commit 77a4229719e511a0d38d9c355317ae1469adeb54
> 
> [SCSI] Retry commands with UNIT_ATTENTION sense codes to fix ext3/ext4 I/O error
> 
> which just went in this May.  Given that we now send barriers and
> discards as FS requests I think it should be reverted, preferably
> already during this cycle, in which the patches to send these requests
> as FS type were added.

Right ... it was the quickest hack to get around the fact that we expect
the caller to do error handling for BLOCK_PC requests and none of the
block discard and barrier code expects to do this.

Once they all go as REQ_TYPE_FS, this code can be removed.

James



--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux