On Wed, Aug 18, 2010 at 04:03:08PM +0200, Jan Kara wrote: > On Wed 18-08-10 05:29:17, Christoph Hellwig wrote: > > Switch to the WRITE_FLUSH_FUA flag for journal commits and remove the > > EOPNOTSUPP detection for barriers. > Well, in the context of just this patch series, the patch is OK so you > can add > Acked-by: Jan Kara <jack@xxxxxxx> > But as soon as blkdev_issue_flush() stops draining the queue, commit when > JBD2_FEATURE_INCOMPAT_ASYNC_COMMIT is set breaks. blkdev_issue_flush already stopped draining queues in Tejun's series. When I talked to Ted last week my impression was that the async commit doesn't rely on the queue draining but only on the cache flushing, but my head is still spinning trying to understand what that code actually does, and especially why. But maybe Ted just meant to say in principle and not with the current code. If everyone is fine with your patch I can include it into the next respin. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
