Nick Piggin <npiggin@xxxxxxxxx> writes:
> - Delete some boring legacy comments because we don't care much about how the
> code used to work, more about the interesting parts of how it works now. So
> comments about lazy LRU may be interesting, but would better be done in the
> LRU or refcount management code.
It would have been nice if you had done all the comment changes in
another patch.
As far as I can see this is only a two liner and it looks obviously
correct.
As a quick experiment I set a systemtap probe for this on my workstation
global first, second
probe kernel.function("*@fs/namei.c:1143") { first++ }
probe kernel.function("*@fs/namei.c:1149") { second++ }
probe end { printf("first %d, second %d\n", first, second) }
and did a quick kernel build, resulting in:
first 22753, second 22753
So yes it looks like the hit rate is about zero for the first case
and the change is good.
Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
-Andi
--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
