On Wed 18-08-10 05:29:18, Christoph Hellwig wrote:
> ext4 already uses synchronous discards, no need to add I/O barriers.
The patch looks ok. But note that in -rc1 the code looks sligthly
differently so you'll need to rediff it.
Honza
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> Index: linux-2.6/fs/ext4/mballoc.c
> ===================================================================
> --- linux-2.6.orig/fs/ext4/mballoc.c 2010-08-17 16:48:50.546274081 +0200
> +++ linux-2.6/fs/ext4/mballoc.c 2010-08-17 16:48:58.896006097 +0200
> @@ -2589,9 +2589,7 @@ static void release_blocks_on_commit(jou
> (unsigned long long)discard_block,
> entry->count);
> ret = sb_issue_discard(sb, discard_block, entry->count,
> - GFP_NOFS,
> - BLKDEV_IFL_WAIT |
> - BLKDEV_IFL_BARRIER);
> + GFP_NOFS, BLKDEV_IFL_WAIT);
> if (ret == EOPNOTSUPP) {
> ext4_warning(sb,
> "discard not supported, disabling");
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
