On Tue, Aug 17, 2010 at 12:27 PM, Venkateswararao Jujjuri (JV)
<jvrao@xxxxxxxxxxxxxxxxxx> wrote:
> Every transport layer may have unique capabilities. This function is employed
> to query and make use of those special/unique cabailities.
> To start with we will be defining P9_CAP_GET_MAX_SG_PAGES.
> If capability(P9_CAP_GET_MAX_SG_PAGES) exists AND returns a value greater
> than 0, it means that the transport can support the transportation
> of that many mapped pages between the client and server.
>
Is there a good reason to make this a function versus a flag/bit-mask
in the transport structure? Having to call an extra function
(hopefully it gets inlined, but its function pointer so I'm thinking
it won't) every client_rpc call seems like a mistake.
Additionally, given we know the page size constant, couldn't we infer
this from a negotiated msize? Transports already have an maxsize
field which limits the msize selections (and defaults? if not maybe it
should?) -- why not just use that?
-eric
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
