Re: [PATCH 2/2] DNS: Fixes for the DNS query module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 06 Aug 2010 03:13:52 +0100 David Howells wrote:

> Fixes for the DNS query module, including:
> 
>  (1) Use 'negative' instead of '-ve' in the documentation.
> 
>  (2) Mark the kdoc comment with '/**' on dns_query().
> 
> Reported-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Thanks, David.


> ---
> 
>  Documentation/networking/dns_resolver.txt |    6 +++---
>  net/dns_resolver/dns_query.c              |    2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/networking/dns_resolver.txt b/Documentation/networking/dns_resolver.txt
> index d8e0ce1..aefd1e6 100644
> --- a/Documentation/networking/dns_resolver.txt
> +++ b/Documentation/networking/dns_resolver.txt
> @@ -96,9 +96,9 @@ implemented in the module can be called after doing:
>       for the default query type it is just a list of comma-separated IPv4 and
>       IPv6 addresses.  The caller must free the result.
>  
> -     The length of the result string is returned on success, and a -ve error
> -     code is returned otherwise.  -EKEYREJECTED will be returned if the DNS
> -     lookup failed.
> +     The length of the result string is returned on success, and a negative
> +     error code is returned otherwise.  -EKEYREJECTED will be returned if the
> +     DNS lookup failed.
>  
>       If _expiry is non-NULL, the expiry time (TTL) of the result will be
>       returned also.
> diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c
> index b33e1f7..03d5255 100644
> --- a/net/dns_resolver/dns_query.c
> +++ b/net/dns_resolver/dns_query.c
> @@ -45,7 +45,7 @@
>  
>  #include "internal.h"
>  
> -/*
> +/**
>   * dns_query - Query the DNS
>   * @type: Query type (or NULL for straight host->IP lookup)
>   * @name: Name to look up
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux