Re: [PATCH 1/3] mm: Stop background writeback if there is other work queued for the thread

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > I don't think this is quite correct.  If the only other callers was
> > fsync_filesystems that would be true, but we also have the odd
> > writeback_if_idle hack in ext4, and the bdi_start_writeback hack
> > in laptop mode. 
>   Yes, I'm aware of these. But do they really matter? bdi_start_writeback()
> hack is almost like background writeback (it's write-it-all thing) and so
> yielding to it does not change much. Similarly the writeback_if_idle thing
> (although that works only for a single sb which makes difference if there
> are several active filesystems on the bdi).
>   But regardless of what other work items actually do, I view background /
> kupdate writeback as the type of thing we do when noone else sends bdi
> dirty data to the backing device.  So if someone has actually idea what to
> write out, we give it priority and then return to doing our background /
> kupdate writeback. What do you think?

Makes sense as long as we keep our current queue with work items indeed.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux