The patch looks correct to me, but I wonder if we shouldn't try to get rid of writeback_in_progress instead. There's just two users, one is the ext4 writeback_if_idle hack, and the other one is balance_dirty_pages. The latter really should only care about about other background reclaim beeing pending, and I have no idea why the former cares - if e.g. any kind of kupdate in the background is pending which just writes out a few inodes on another fs on the same bdi it's exiting. The XFS variant of this does unconditional writeback for all inodes on the sb. Long term I wonder if we shouldn't get rid of the work list entirely, and just have a few targets for the flusher thread - we just set a target and wake it up, and it keeps running until all targets are met. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
