On Mon, 02 Aug 2010, Valdis.Kletnieks@xxxxx wrote: > On Mon, 02 Aug 2010 13:20:01 +0200, Miklos Szeredi said: > > > Index: linux-2.6/fs/dcache.c > > =================================================================== > > --- linux-2.6.orig/fs/dcache.c 2010-07-06 18:08:16.000000000 +0200 > > +++ linux-2.6/fs/dcache.c 2010-07-06 18:08:19.000000000 +0200 > > @@ -1977,8 +1977,7 @@ global_root: > > * @buffer: buffer to return value in > > * @buflen: buffer length > > * > > - * Convert a dentry into an ASCII path name. If the entry has been deleted > > - * the string " (deleted)" is appended. Note that this is ambiguous. > > + * Convert a dentry into an ASCII path name. > > * > > * Returns a pointer into the buffer or an error code if the > > * path was too long. > > I'd prefer the comment about it being ambiguous remain. I'm waiting > to see how long it takes for somebody to create a security hole by > creating a file called '/etc/some/thing/important (deleted)' and > having some software Do The Wrong Thing instead to > /etc/some/thing/important. The same comment is left intact on top of d_path(). It is removed from __d_path() because this function no longer appends "(deleted)". Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
