Re: [PATCH 2/2] add f_flags to struct statfs(64)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 17, 2010 at 11:41 PM, Christoph Hellwig <hch@xxxxxx> wrote:
>
>  (1) add new system calls
>  (2) drop the ST_VALID flag and only look at the flags field for
>     2.6.36+ kernels.
>  (3) keep the ST_VALID flag in my patches and only look at the flags
>     field in glibc for 2.6 kernels
>
> (1) is pretty ugly, and Linus already vetoed it, (2) is okayish, but
> prevents distros from backporting this easy speedup in a useful way,
> so I'd prefer variant (3).  If Uli is okay with that we should put
> my second version of the patches into the vfs tree and pull them
> for 2.6.36.  If version (2) is preferred I can update the patches
> again.

I certainly don't mind the ST_VALID field. I don't think it's strictly
_necessary_, but there's nothing really wrong with it either. So
personally I'm fine with either 2 or 3.

                       Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux