Looks correct, but I would do this slightly different. Add a new bdi_writeback_start_thread helper, and then call it from the list walk as long as there are bdis that need a thread. Only break out of the loop once nothing needs to be done and then sleep. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html