On Sunday 04 July 2010 09:30:50 Sam Ravnborg wrote: > > default: > > VPRINTK(DRIVER_NAME": Unknown ioctl for %s (%x)\n", pd->name, cmd); > > - return -ENOTTY; > > + ret = -ENOTTY; > > } > > + unlock_kernel(); > > > > return 0; > > } > You are loosing the return result here in the two error situations above. > Initialise ret to 0 and return ret seems the easy way to do it. > > The rest looked ok - I only looked at the patches. Good catch, thanks! I've updated the patch and pushed it out to my git tree. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
