On Fri, Jul 02, 2010 at 12:38:22AM +0200, Christoph Hellwig wrote: > I have patches in my queue that should fix this as a side effect. > > First thing is splitting the set_xstate method currently only > used by XFS into ->quota_enable, ->quota_disable and ->quota_remove, > second is using merging ->quota_disable and ->quota_off, third > is switching ocfs2 to ->quota_disable and fourth is taking the > path lookup from ->quota_on into the caller. > > I'll try to get them out to the list in a couple of days. Shouldn't have replied in the middle of the night. The above doesn't fix the deadlock yet, but by allowing different methods would allow to fix it in hacky ways. Now the real questions is: do we need to support quota files on different filesystems? For ext3/4 and reiserfs with journaled quota we already reject that. If we always reject it or even further restrict quota files to sit in the root of the filesystem we can replace the kernel_path with a relative lookup that doesn't cross mountpoints. In the idea case of restricting it to the root that would be just a lookup_one_len, just as we do in dquot_quota_on_mount, otherwise something hand crafted. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
