Re: [PATCH] ext2:delete misused ext2_free_blocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/01/2010 06:57 AM, Dan Carpenter wrote:
On Wed, Jun 30, 2010 at 06:21:27PM +0800, Peter Pan wrote:
if ext2_new_blocks returns error, no blocks need to be freed.

Hi Peter,

Your patch isn't right.  The original code is OK as is.

Are you seeing a kernel panic?  Perhaps we can help you fix it.
Oh, I know that the original code is good now.
I didn't see a kernel panic, thank you for your guide.
regards,
dan carpenter

Signed-off-by: Peter Pan<wppan@xxxxxxxxxxxxxxxxx>
---
  fs/ext2/inode.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index 3675088..f858847 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -385,6 +385,8 @@ static int ext2_alloc_blocks(struct inode *inode,
  	ext2_fsblk_t current_block = 0;
  	int ret = 0;

+	*err = -ENOSPC;
+
  	/*
  	 * Here we try to allocate the requested multiple blocks at once,
  	 * on a best-effort basis.
@@ -421,8 +423,6 @@ static int ext2_alloc_blocks(struct inode *inode,
  	*err = 0;
  	return ret;
  failed_out:
-	for (i = 0; i<index; i++)
-		ext2_free_blocks(inode, new_blocks[i], 1);
  	return ret;
  }

--
1.6.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Regards

--
Peter Pan
Red Flag Software Co.,Ltd

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux