Hi, On Mon, Jun 28, 2010 at 01:00:28PM -0700, Andrew Morton wrote: > Surely it would be better to fix the tools which display this info > rather than making the kernel tell fibs. The strncpy in get_task_comm() is totally wrong -- it's testing the length of task->comm. Why should get_task_comm not take a destination buffer length argument? At least consider v2 of the patch -- it just fixes the get_task_comm definition and callers. But, if not, then patches to the kernel that include printk(..., get_task_comm(...) ...) shouldn't be considered flawed[1]. -Kees [1] http://lkml.org/lkml/2010/6/23/132 -- Kees Cook Ubuntu Security Team -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
