> if (io_end->flag != EXT4_IO_UNWRITTEN){ > ext4_free_io_end(io_end); > iocb->private = NULL; > - goto out; > +out: > + if (is_async) > + aio_complete(iocb, ret, 0); > + return; I'd suggest keeping the out label at the end of the function. Without that the code gets unreadable very quickly. > io_end->size = size; > - io_end->flag = EXT4_IO_UNWRITTEN; Why is this initialization removed? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html