On Wed, 2010-06-23 at 11:07 +0900, J. R. Okajima wrote: > Ian Kent: > > I may be missing something about this, but why is it safe to use > > iterate_mounts(), since it doesn't take the vfsmount_lock when > > traversing the list of mounts? > > The sample code was not correct. > We need to acquire vfsmount_lock or down_read(namespace_sem). This is looking more and more suspect the more I dig. The only place iterate_mounts() is called is within the audit subsystem AFAICS, and I don't see where vfsmount_lock is taken in that code. OTOH, in fs/namespace.c it is pretty clear that vfsmount->mnt_list is protected by the vfsmount_lock. Ummm ... that's gota be broken but maybe someone can give a reason why it isn't? Ian -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
