On Fri 18-06-10 12:21:35, Peter Zijlstra wrote: > On Thu, 2010-06-17 at 20:04 +0200, Jan Kara wrote: > > + /* > > + * Now we can wakeup the writer which frees wc entry > > + * The barrier is here so that woken task sees the > > + * modification of wc. > > + */ > > + smp_wmb(); > > + __wake_up_locked(&bdi->wb_written_wait, TASK_NORMAL); > > wakeups imply a wmb. Thanks. Removed smp_wmb and updated comment. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html