Re: [PATCH 1/2] block: remove wrappers for request type/flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Index: linux-2.6/drivers/block/virtio_blk.c
> ===================================================================
> --- linux-2.6.orig/drivers/block/virtio_blk.c	2010-06-16 21:15:41.120004099 +0200
> +++ linux-2.6/drivers/block/virtio_blk.c	2010-06-17 13:21:18.988006543 +0200
> @@ -65,13 +65,16 @@ static void blk_done(struct virtqueue *v
>  			break;
>  		}
>  
> -		if (blk_pc_request(vbr->req)) {
> +		switch (vbr->req->cmd_type) {
> +		case REQ_TYPE_BLOCK_PC:
>  			vbr->req->resid_len = vbr->in_hdr.residual;
>  			vbr->req->sense_len = vbr->in_hdr.sense_len;
>  			vbr->req->errors = vbr->in_hdr.errors;
> -		}
> -		if (blk_special_request(vbr->req))
> +			break;
> +		case REQ_TYPE_SPECIAL:
>  			vbr->req->errors = (error != 0);
> +			break;
> +		}

This conversion also makes gcc unhappy, since you don't supply a default
case. A bit silly since it's the end of the processing, I'll add one
just to shut it up.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux