On Tue 15-06-10 19:59:35, Christoph Hellwig wrote: > On Tue, Jun 15, 2010 at 07:54:13PM +0200, Jan Kara wrote: > > But this is buggy isn't it? writeback_inodes_sb() returns as soon as > > flusher threads start submitting the IO. So we release s_umount too early - > > flusher threads can be still writing out inodes for our work. It's exactly > > cases like this why I don't like the work to be called "done" when flusher > > threads actually still do it... > > Now that writeback_inodes_sb uses bdi_queue_work_onstack, wb_do_writeback > doesn't signal completion until I/O is submitted. So the locking should > be safe. Yay, I see. But it's a bit subtle... Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
