On Fri, Jun 04, 2010 at 02:39:34PM -0400, Christoph Hellwig wrote: > The ttry code currently abuses the file anchor for the per-sb file list > to track instances of a given tty. But there's no good reason for > that, we can just install a proxy object in file->private that gets > added to the list and points to the tty and keep the list away from > VFS internals. Well this code looks like the error handling is broken and it's pretty convoluted to fix (eg. tty_release requires tty from filp but is called to clean up code from before tty file private structure is allocated). So I really prefer to put my original patch first. I really don't see how it makes the tty code more of a special case. In both cases, it must know that the vfs does not require the file's presence on the s_files list so it can be reused for tty code. After my patch, it no longer knows any details about how the vfs does locking for the list. Possibly a lighter way to do what you want is to have the vfs not use fu_list for device inodes and define drivers to be allowed to use it for their own purpose. But that is easily possible after my patch. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
