On Thu, Jun 03, 2010 at 11:40:54AM -0700, Kees Cook wrote: > At this point, I believe I've addressed the specific concerns that Al Viro, > Eric Paris, and a few others pointed out. What else needs fixing? The hell you have. Let me spell it out for you: 1) You _still_ have not posted the analysis of changes it causes, let alone explained why they are the right thing to do. 2) You are still doing that for each symlink, no matter where in the path it might be. Do (1) and you'll see why it is a BS. 3) You have not bothered to explain why e.g. stat(2) should fail on such symlinks. Nevermind figuring out which syscalls need that and which do not. Again, (1) would be the starting point required for the rest. And it is needed to decide how to deal with these checks. Really. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
