On Sun 30-05-10 22:50:18, Christoph Hellwig wrote: > Split up the block_write_begin implementation - __block_write_begin is a new > trivial wrapper for block_prepare_write that always takes an already > allocated page and can be either called from block_write_begin or filesystem > code that already has a page allocated. Remove the handling of already > allocated pages from block_write_begin after switching all callers that > do it to __block_write_begin. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Index: linux-2.6/fs/buffer.c > =================================================================== > --- linux-2.6.orig/fs/buffer.c 2010-05-30 22:32:22.754253961 +0200 > +++ linux-2.6/fs/buffer.c 2010-05-30 22:40:16.496254519 +0200 > @@ -1833,9 +1833,10 @@ void page_zero_new_buffers(struct page * > } > EXPORT_SYMBOL(page_zero_new_buffers); > > -static int __block_prepare_write(struct inode *inode, struct page *page, > - unsigned from, unsigned to, get_block_t *get_block) > +int block_prepare_write(struct page *page, unsigned from, unsigned to, > + get_block_t *get_block) > { > + struct inode *inode = page->mapping->host; This new variable doesn't seem to be used... Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html