On Wed, Jun 02, 2010 at 01:00:14AM +0200, Jan Kara wrote: > On Sun 30-05-10 22:49:42, Christoph Hellwig wrote: > > Move the call to vmtruncate to get rid of accessive blocks to the callers > > in prepearation of the new truncate calling sequence. This was only done > > for DIO_LOCKING filesystems, so the __blockdev_direct_IO_newtrunc variant > > was not needed anyway. Get rid of blockdev_direct_IO_no_locking and > > it's _newtrunc variant while at it as just opencoding the two additional > > paramters is shorted than the name suffix. > Hmm, I've noticed that you didn't add truncate code to btrfs. I see that > it already does some recovery after direct IO error but I'd like to make > sure that it won't be broken by your patches... Chris? As mentioned above __blockdev_direct_IO only called vmtruncate for the DIO_LOCKING, which does not include btrfs. And yes, there's quite a bit of things that need cleanup but didn't have it before due to the way the cleanup code was hidden, but that's not something I want to do in this transformation series. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
