On Mon, May 31, 2010 at 11:40:30AM +0200, Christoph Hellwig wrote: > Replace inode_setattr with opencoded variants of it in all callers. This > moves the remaining call to vmtruncate into the filesystem methods where it > can be replaced with the proper truncate sequence. > > In a few cases it was obvious that we would never end up calling vmtruncate > so it was left out in the opencoded variant: > > spufs: explicitly checks for ATTR_SIZE earlier > btrfs,hugetlbfs,logfs,dlmfs: explicitly clears ATTR_SIZE earlier > ufs: contains an opencoded simple_seattr + truncate that sets the filesize just above > > In addition to that ncpfs called inode_setattr with handcrafted iattrs, > which allowed to trim down the opencoded variant. The series all looks pretty good, ends up being quite a lot cleaner in the core code. This last patch is a question of a bit of churn and duplicated code with the result of cleaner core code, and more explicitly putting vmtruncate in the hands of the fs maintainers. I have a bunch of fs conversions (several from you) I was going to send to maintainers, they'll clash a bit. I'll see what ends up being merged in 2.6.35 and try to fix up what I've got. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
