Re: [PATCH 1/2] drop unused dentry argument to ->fsync

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 28, 2010 at 02:18:44PM +0100, Al Viro wrote:
> On Fri, May 28, 2010 at 08:35:26AM -0400, Theodore Tso wrote:
> > 
> > On May 28, 2010, at 7:42 AM, tytso@xxxxxxx wrote:
> > 
> > > On Wed, May 26, 2010 at 05:53:25PM +0200, Christoph Hellwig wrote:
> > >> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > >> 
> > >> Index: linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
> > >> ===================================================================
> > >> --- linux-2.6.orig/arch/powerpc/platforms/cell/spufs/file.c	2010-05-25 19:28:04.965004819 +0200
> > >> +++ linux-2.6/arch/powerpc/platforms/cell/spufs/file.c	2010-05-25 19:55:33.804006007 +0200
> > >> @@ -1849,8 +1849,7 @@ out:
> > >> 	return ret;
> > >> }
> > >> 
> > >> -static int spufs_mfc_fsync(struct file *file, struct dentry *dentry,
> > >> -			   int datasync)
> > >> +static int spufs_mfc_fsync(struct file *file int datasync)
> > >                                             ^^^^^
> > > Typo: Missing comma, this won't compile.
> > 
> > Oops, looks like emacs in tty mode (when fired from mutt) screwed up my screen, and I saw something quite different from what you posted.   Sorry about that, please ignore.
> 
> No, you are right, it's a typo; I've caught two more (ntfs and ocfs2, IIRC),
> but actually missed that one.

Ah, so it was actually the Mac's e-mail that screwed up the display.
Heh.  (Yeah, I use a Mac for reading in bed, what can I say, it's
lightweight. :-)

Sorry for the confusion.

						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux