> On Sat, Apr 17, 2010 at 01:03:32AM +0200, Johannes Weiner wrote: > > On Fri, Apr 16, 2010 at 11:51:26AM +0900, KOSAKI Motohiro wrote: > > > > Two variables are declared that are unnecessary in shrink_zone() as they > > > > already exist int the scan_control. Remove them > > > > > > > > Signed-off-by: Mel Gorman <mel@xxxxxxxxx> > > > > > > ok. > > > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > > > > You confuse me, you added the local variables yourself in 01dbe5c9 > > for performance reasons. Doesn't that still hold? > > To avoid a potential regression, I've dropped the patch. I'm ok either. Commit 01dbe5c9 issue was only observed on ia64. so it's not important. But at making 01dbe5c9 time, I didn't realized this stack overflow issue. So, I thought "Oh, It's no risk. should go!". but if stack reducing is important, I'm ok to drop this one. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
