On Wed, May 26, 2010 at 11:54:43PM +0200, Jan Kara wrote:
> > - } else if ((block -= 7) < 256) {
> > - offsets[n++] = 7;
> > + } else if ((block -= DIRCOUNT) < INDIRCOUNT(sb)) {
> This modification of 'block' in the if condition is a blatant violation
> of the kernel coding style.
The hell it is. [...said the guy who'd written it that way in the first place]
It _is_ idiomatic C for that kind of thing ("we've got several adjacent ranges,
find which one had we hit and how far from its start").
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
