On Tue 25-05-10 15:29:23, Dmitry Monakhov wrote:
> Generic pcpu counter has some memory overhead but it is negligible for
> modern systems, and embedded systems compiles without quota support.
> And code reuse is always good thing. This patch should fix complain
> from preemptive kernels which was introduced by dde9588853b1bde
...
> static ctl_table fs_dqstats_table[] = {
> {
> .procname = "lookups",
> .data = &dqstats.stat[DQST_LOOKUPS],
> - .maxlen = sizeof(int),
> + .maxlen = sizeof(s64),
You use proc_dounlongvec_minmax so .maxlen should be sizeof(unsigned
long)...
> @@ -253,29 +252,12 @@ enum {
> };
>
> struct dqstats {
> - int stat[_DQST_DQSTAT_LAST];
> + struct percpu_counter cntp[_DQST_DQSTAT_LAST];
> + s64 stat[_DQST_DQSTAT_LAST];
^^^ And here you should have unsigned long as well. Otherwise
you would see the value as two 32-bit numbers on 32-bit archs.
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
